Disable unsused features from flume dependency#653
Merged
h3nill merged 1 commit intobytebeamio:mainfrom Jul 13, 2023
Merged
Conversation
Contributor
Author
|
Is a Based on the previous entries it looks to me like this wouldn't appear in the list, but I can include a mention if you prefer. |
|
no changelog entry not required for this |
|
Thank you @domenicquirl! |
carlocorradini
pushed a commit
to carlocorradini/rumqtt
that referenced
this pull request
Aug 3, 2023
Co-authored-by: Domenic Quirl <DomenicQuirl@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the dependency on
flumeto only enable itsasyncfeature instead of all features that are enabled by default. The motivation for this change is that neitherrumqttcnorrumqttdneed to select between (i.e., wait for any one of multiple) messages from multiple channels. However, theselectfeature offlumeis enabled by default, together with itseventual-fairnessfeature that ensures that channels in a selector cannot make other ones starve. To do so, a source of randomness is required which is obtained through additional dependencies that this PR aims to avoid for both users and developers ofrumqtt.Type of change
Miscellaneous (related to maintanance)
Checklist:
cargo fmt(onlyCargo.tomls are changed)CHANGELOG.mdif its relevant of user of the library. If its not relevant mention why.