Skip to content

Add qos2 support in Broker#604

Merged
swanandx merged 19 commits intomainfrom
broker-qos2
Jul 24, 2023
Merged

Add qos2 support in Broker#604
swanandx merged 19 commits intomainfrom
broker-qos2

Conversation

@swanandx
Copy link
Contributor

@swanandx swanandx commented Apr 6, 2023

  • Enable QoS2 support
  • Fix a bug in scheduler: We had to wait until a new packet is there so the connection will get scheduled and then we send the pending ack ( PubRec ) of older packet.

Even if the scheduler's behavior is changed for a particular case, it shouldn't affect the existing users. Therefore, this isn't a breaking change.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if its relevant of user of the library. If its not relevant mention why.

@stale stale bot added the stale Not moving forward; blocked label Apr 26, 2023
@h3nill h3nill self-requested a review May 2, 2023 11:17
@stale stale bot removed the stale Not moving forward; blocked label May 2, 2023
@stale stale bot added the stale Not moving forward; blocked label Jun 8, 2023
@stale stale bot removed the stale Not moving forward; blocked label Jun 12, 2023
@stale stale bot added the stale Not moving forward; blocked label Jul 2, 2023
@stale stale bot removed the stale Not moving forward; blocked label Jul 14, 2023
Copy link

@h3nill h3nill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swanandx swanandx merged commit 91939fe into main Jul 24, 2023
@swanandx swanandx deleted the broker-qos2 branch July 24, 2023 06:17
carlocorradini pushed a commit to carlocorradini/rumqtt that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants