Conversation
h3nill
reviewed
Apr 6, 2023
| pub max_payload_size: usize, | ||
| pub max_inflight_count: u16, | ||
| pub max_inflight_size: usize, | ||
| pub max_inflight_count: usize, |
There was a problem hiding this comment.
I think we should update this variable name to a more descriptive max_connection_buffer_len that we use internally in Network, so it is not confused with max allowed inflight publish messages which is currently a constant set to 100 (i.e. MAX_INFLIGHT in src/router/iobufs.rs).
h3nill
reviewed
Apr 6, 2023
h3nill
reviewed
Apr 6, 2023
Closed
|
We have merged this internally, we will create a rumqttd release with this changes soon. |
carlocorradini
pushed a commit
to carlocorradini/rumqtt
that referenced
this pull request
Aug 3, 2023
Co-authored-by: henil <dedaniahenil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Breaking:
router.max_read_lentorouter.max_outgoing_packet_countin config and set its value from 10240 to 200Checklist:
cargo fmtCHANGELOG.mdif its relevant of user of the library. If its not relevant mention why.