Conversation
| | Environment Variable | Description | | ||
| |----------------------|-------------------------------------------------------------------------------| | ||
| | DISCOVER | How `haproxy.cfg` will be created: `static`, `docker` or `swarm` | | ||
| | LOOKUP_LABEL | (Optional) The key will search to match resources. Default: `easyhaproxy`. | |
There was a problem hiding this comment.
Should this have HAPROXY_ as the prefix so it matches the other env vars?
There was a problem hiding this comment.
There was a problem hiding this comment.
No I meant should it be renamed to HAPROXY_LOOKUP_LABEL?
There was a problem hiding this comment.
I don't know. When we say "HAPROXY_LOOKUP_LABEL" I understand that it should be a HAPROXY feature, which is not completely true, since the service discovery is not a HAPROXY feature.
But I agree, I don't like LOOKUP_LABEL name too. I just didn't find one better.
There was a problem hiding this comment.
Or EASYHAPROXY_LABEL_PREFIX?
There was a problem hiding this comment.
I like it. Let me change that.
There was a problem hiding this comment.
Based on that, can I change the env from DISCOVER to EASYHAPROXY_DISCOVER ?
Organizing code to refactory labels
Currently, the lookup label is hard coded to
easyhaproxy.This PR adds the possibility to customize this label by adding an environment variable
LOOKUP_LABELto the byjg/easyhaproxy container.This fixes issue #11