Conversation
Contributor
|
Could definitions be dynamic now that they are basically dictionaries? Basically, is easyhaproxy.definitions necessary still? |
Owner
Author
|
Yeah, I thought that too. It becomes unnecessary, but it will involve some refactory. Let me think, 99% sure I'll remove it, I just need to see how to implement it in the code. |
Owner
Author
|
I found a way to implement the definitions dynamically. So, there Is no need to use |
Contributor
|
This is great! I can probably include this in the next dokku release if this and the other mr are merged this weekend or sometime Monday :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR inverts the label pattern.
we have
easyhaproxy.[property].[definition]And it will become:
easyhaproxy.[definition].[property]