Support for STM32 architecture + STM RTC clock (take#2)#39
Support for STM32 architecture + STM RTC clock (take#2)#39bxparks merged 2 commits intobxparks:developfrom arkhipenko:develop
Conversation
|
The content looks good. But you have converted all these files into DOS format with (\r\n) instead of (\n) line termination. So the Can you fix your git config and try again? This may help you: |
|
I switched to Linux specifically to fix the filenames as the windows version would not pick up the difference. |
|
If you can't fix it, please keep this PR open and I'll find a way to merge this code in properly myself. I got some STM32 on order, so I should be able to actually test things too. It sounds like it might be worth tracking down these git config problems on your Windows or Linux machine. In theory, git should be doing these NL/LF conversions for you automatically for text files, so these problems shouldn't happen. |
Git for Windows was doing CR/LF conversion properly, but missed the filename changes... |
|
Success! I think you fixed the CR/LF problem. I see a few trailing whitespace nits, but I can fix those later. Everything else looks great. Since I got the STM32s on order, I think I'll wait until they arrive so that I can test this code myself. Thanks for the PR! (If I don't update this within about a month, you can ping me to see what's up.) |
|
Great. Thanks. Q: for production, shall I compile against your |
|
The trunk for all development is |
|
Actually, to avoid dealing with conflicts later, I am going to merge this into |
…merging in STM32 code from #39
Hi,
this is take 2 after screwing up the branches - should be ok now and off the latest
developbranch.Cheers and thank you for this extremely useful library!
Anatoli