add support for global pager option #1392
Merged
shahzebsiddiqui merged 6 commits intodevelfrom Feb 21, 2023
Merged
Conversation
--pager options from 'buildtest bc find', 'buildtest bc sm', 'buildtest history list', 'buildtest cg view', and 'buildtest rt' update bash completion script accordingly
… instance where --pager was shown in subcommand when it will be available as a global option
…ildtest buildspec find' and 'buildtest config'. Remove unnecessary tests from running with 'buildtest rt sm' when using coloring with paging option since colors are not shown with paging
prathmesh4321
approved these changes
Feb 21, 2023
Collaborator
prathmesh4321
left a comment
There was a problem hiding this comment.
Hi @shahzebsiddiqui , LGTM !
Member
Author
|
thanks @prathmesh4321 |
shahzebsiddiqui
added a commit
that referenced
this pull request
Mar 1, 2023
we remove global option '--pager' now its back in the subcommands. update the bash completion script we also removed logic for '--color' selection in bash completion in subcommands which is not being used since this is taken care of at the global level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@prathmesh4321 @Xiangs18 @jscook2345.
This will address #1388
This PR will do the following
buildtest --pagerand remove--pageroption from each subcommands in particularbuildtest config view,buildtest buildspec find,buildtest buildspec summary,buildtest reportbuildtest rt smwhere paging with color was being tested which is not necessary since paging output doesn't show color.buildtest helpto account for--pageroptionWith this change, we will remove the duplication of
--pageroption when building out the command line options however user may not know when--pagerwill work. Not all commands support paging, it only works with tables. Perhaps we have a brief section on paging and show some commands where paging is supported.Can you please review this PR