Skip to content

Assert Less Than for Status Check#1382

Merged
shahzebsiddiqui merged 7 commits intodevelfrom
sean_assert_lessthan
Feb 10, 2023
Merged

Assert Less Than for Status Check#1382
shahzebsiddiqui merged 7 commits intodevelfrom
sean_assert_lessthan

Conversation

@Xiangs18
Copy link
Collaborator

@Xiangs18 Xiangs18 commented Feb 9, 2023 •
edited
Loading

Hi @shahzebsiddiqui, please review this MR and provide feedback.

pic

@Xiangs18 Xiangs18 linked an issue Feb 9, 2023 that may be closed by this pull request
Assert Less Than for Status Check #1315
Closed
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 69.46% // Head: 69.08% // Decreases project coverage by -0.38% ⚠️

Coverage data is based on head (20a1f60) compared to base (f544d4a).
Patch coverage: 2.78% of modified lines in pull request are covered.

❗ Current head 20a1f60 differs from pull request most recent head 572796b. Consider uploading reports for the commit 572796b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #1382      +/-   ##
==========================================
- Coverage   69.46%   69.08%   -0.38%     
==========================================
  Files          57       57              
  Lines        6277     6313      +36     
  Branches     1112     1118       +6     
==========================================
+ Hits         4360     4361       +1     
- Misses       1915     1950      +35     
  Partials        2        2
Impacted Files Coverage Δ
buildtest/builders/base.py 55.43% <0.00%> (-0.32%) ⬇️
buildtest/buildsystem/checks.py 5.77% <3.03%> (-0.26%) ⬇️
buildtest/tools/stylecheck.py 89.83% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shahzebsiddiqui shahzebsiddiqui removed their request for review February 9, 2023 19:29
@shahzebsiddiqui
Copy link
Member

shahzebsiddiqui commented Feb 9, 2023

@prathmesh4321 can you please review

@Xiangs18 Xiangs18 requested review from shahzebsiddiqui and removed request for shahzebsiddiqui February 9, 2023 19:31
prathmesh4321
prathmesh4321 requested changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@prathmesh4321 prathmesh4321 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xiangs18 Can you also create a symlink in https://github.com/buildtesters/buildtest/tree/devel/tests/builders for the assert less than test in https://github.com/buildtesters/buildtest/tree/devel/tutorials/perf_checks if not done yet, so that the example test also gets tested. See #1361 for reference.

@prathmesh4321
Copy link
Collaborator

prathmesh4321 commented Feb 9, 2023

@prathmesh4321 can you please review

@shahzebsiddiqui Sure!

@Xiangs18
Copy link
Collaborator Author

Xiangs18 commented Feb 10, 2023

Hey @prathmesh4321, updated!

@shahzebsiddiqui shahzebsiddiqui self-requested a review February 10, 2023 15:02
@shahzebsiddiqui
Copy link
Member

shahzebsiddiqui commented Feb 10, 2023

thanks @Xiangs18 this looks good. thanks @prathmesh4321 for reviewing this. I resolved all threads. Merging this in 🚀

@shahzebsiddiqui shahzebsiddiqui merged commit 7f06b85 into devel Feb 10, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the sean_assert_lessthan branch February 10, 2023 15:03
@shahzebsiddiqui shahzebsiddiqui mentioned this pull request Mar 10, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prathmesh4321 prathmesh4321 prathmesh4321 requested changes

@shahzebsiddiqui shahzebsiddiqui Awaiting requested review from shahzebsiddiqui

Assignees

@Xiangs18 Xiangs18

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assert Less Than for Status Check

3 participants

@Xiangs18 @shahzebsiddiqui @prathmesh4321