Skip to content

Assert not equal status check#1361

Merged
shahzebsiddiqui merged 3 commits intodevelfrom
assert_ne
Feb 1, 2023
Merged

Assert not equal status check#1361
shahzebsiddiqui merged 3 commits intodevelfrom
assert_ne

Conversation

@prathmesh4321
Copy link
Collaborator

Hi @shahzebsiddiqui I have added assert not equal. Please review the PR.
Screen Shot 2023-01-31 at 11 44 22 PM

Screen Shot 2023-01-31 at 11 43 51 PM

@prathmesh4321 prathmesh4321 linked an issue Feb 1, 2023 that may be closed by this pull request
@shahzebsiddiqui
Copy link
Member

can you create a hyperlink for the example test where actual test is in https://github.com/buildtesters/buildtest/tree/devel/tutorials/perf_checks and then the symlink is in https://github.com/buildtesters/buildtest/tree/devel/tests/builders for each test so that the example test is also the one that is tested.

We can potentially use the one in the tutorials/perf_checks as a means for user-facing docs

@shahzebsiddiqui
Copy link
Member

shahzebsiddiqui commented Feb 1, 2023

@prathmesh4321 please fix the documentation build there is an error on line 319 due to change in filename
Screen Shot 2023-02-01 at 1 54 59 PM

@prathmesh4321
Copy link
Collaborator Author

can you create a hyperlink for the example test where actual test is in https://github.com/buildtesters/buildtest/tree/devel/tutorials/perf_checks and then the symlink is in https://github.com/buildtesters/buildtest/tree/devel/tests/builders for each test so that the example test is also the one that is tested.

We can potentially use the one in the tutorials/perf_checks as a means for user-facing docs

@shahzebsiddiqui I have added symlinks to other tests.

Screen Shot 2023-02-01 at 12 59 15 PM

@prathmesh4321
Copy link
Collaborator Author

@prathmesh4321 please fix the documentation build there is an error on line 319 due to change in filename Screen Shot 2023-02-01 at 1 54 59 PM

Done !

Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzebsiddiqui shahzebsiddiqui merged commit 37ebad0 into devel Feb 1, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the assert_ne branch February 1, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assert not equal

2 participants