Skip to content

Added top level argument color option "buildtest --color"#1280

Merged
shahzebsiddiqui merged 1 commit intodevelfrom
issue_1275
Oct 24, 2022
Merged

Added top level argument color option "buildtest --color"#1280
shahzebsiddiqui merged 1 commit intodevelfrom
issue_1275

Conversation

@prathmesh4321
Copy link
Collaborator

@prathmesh4321 prathmesh4321 commented Oct 19, 2022

Added buildtest --color option

image

@prathmesh4321 prathmesh4321 linked an issue Oct 19, 2022 that may be closed by this pull request
[FEATURE]: add top level argument color option 'buildtest --color' #1275
Closed
2 tasks
@codecov
Copy link

codecov bot commented Oct 19, 2022 •
edited
Loading

Codecov Report

Base: 77.94% // Head: 81.69% // Increases project coverage by +3.75% 🎉

Coverage data is based on head (90db68f) compared to base (e84d5d3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #1280      +/-   ##
==========================================
+ Coverage   77.94%   81.69%   +3.75%     
==========================================
  Files          55       55              
  Lines        5944     5893      -51     
  Branches     1032     1041       +9     
==========================================
+ Hits         4633     4814     +181     
+ Misses       1310     1079     -231     
+ Partials        1        0       -1
Impacted Files Coverage Δ
buildtest/cli/help.py 94.44% <ø> (-0.05%) ⬇️
buildtest/cli/__init__.py 91.58% <100.00%> (-0.06%) ⬇️
buildtest/cli/compilers.py 82.59% <100.00%> (+25.73%) ⬆️
buildtest/builders/base.py 69.96% <0.00%> (+1.55%) ⬆️
buildtest/cli/build.py 94.52% <0.00%> (+1.77%) ⬆️
buildtest/buildsystem/builders.py 78.31% <0.00%> (+1.81%) ⬆️
buildtest/executors/setup.py 90.82% <0.00%> (+1.93%) ⬆️
buildtest/builders/script.py 78.21% <0.00%> (+3.85%) ⬆️
buildtest/config.py 64.50% <0.00%> (+4.50%) ⬆️
buildtest/utils/timer.py 88.89% <0.00%> (+11.11%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shahzebsiddiqui
Copy link
Member

shahzebsiddiqui commented Oct 20, 2022

hi @prathmesh4321 can you please confirm this also works with buildtest --color blue history list and also buildtest --color blue report list. Please see codecov and regression test to see whether line-coverage is required for the color options.

@shahzebsiddiqui
Copy link
Member

shahzebsiddiqui commented Oct 20, 2022

It looks like we are missing coverage when buildtest report summary is run without color can you please add coverage for this
Uploading Screen Shot 2022-10-20 at 3.59.59 PM.png…

@prathmesh4321
Copy link
Collaborator Author

prathmesh4321 commented Oct 21, 2022

hi @prathmesh4321 can you please confirm this also works with buildtest --color blue history list and also buildtest --color blue report list. Please see codecov and regression test to see whether line-coverage is required for the color options.

buildtest --color blue history list
image

buildtest --color blue report list
image

@shahzebsiddiqui shahzebsiddiqui merged commit 4adb9a0 into devel Oct 24, 2022
@shahzebsiddiqui shahzebsiddiqui deleted the issue_1275 branch October 24, 2022 15:30
shahzebsiddiqui added a commit that referenced this pull request Oct 25, 2022
@shahzebsiddiqui
Merge pull request #1282 from buildtesters/follow-up-MR-1280
9076e6e 
Follow-Up Merge request to PR #1280 (#1280 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzebsiddiqui shahzebsiddiqui Awaiting requested review from shahzebsiddiqui

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE]: add top level argument color option 'buildtest --color'

2 participants

@prathmesh4321 @shahzebsiddiqui