Issue 349 buildpack and clusterbuildpack ref#352
Issue 349 buildpack and clusterbuildpack ref#352chenbh merged 6 commits intobuildpacks-community:mainfrom
Conversation
|
@mailprak #349 is referring to the fact that the We need to display the [Cluster]Buildpacks that are actually used by the Builder instead of every single one on the cluster. |
|
I forgot to mention it in the original issue, but do you mind also doing the same thing for |
sure |
Display buildpack and clusterbuildpack in the status for builder and clusterbuilder
removes unused test
|
@chenbh have made the changes. Please review. |
pkg/commands/builder/status.go
Outdated
| return err | ||
| } | ||
|
|
||
| cpTableWriter, err := commands.NewTableWriter(writer, "BuildpackName", " BuildpackKind") |
There was a problem hiding this comment.
nit: the column headers should be more readable Buildpack Name, Buildpack Kind
| for _, entry := range bldr.Spec.Order { | ||
| for _, ref := range entry.Group { | ||
| if ref.ObjectReference.Name != "" && ref.ObjectReference.Kind != "" { | ||
| err := cpTableWriter.AddRow(ref.ObjectReference.Name, ref.ObjectReference.Kind) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
| } | ||
| cpTableWriter.Write() | ||
| } |
There was a problem hiding this comment.
Can you run gofmt on your files? I think there's some weird whitespace padding in here
| return err | ||
| } | ||
|
|
||
| cpTableWriter, err := commands.NewTableWriter(writer, "ClusterBuildpackName", " ClusterBuildpackKind") |
|
Sorry for the delay, added some comments |
Updates header names and formatting the file
Update Test cases for header name
…uildpack-ref Issue 349 buildpack and clusterbuildpack ref
Issue : #349