[Issue-324] Removes logic that parses registry host when using `kp cr…#328
Merged
[Issue-324] Removes logic that parses registry host when using `kp cr…#328
Conversation
…eate secret --registry` flag, fixes bug that caused dockerhub registry to parse incorrectly Signed-off-by: Caroline Scherf <fcaroline@vmware.com>
Contributor
|
Since we are changing behavior, do you think we should leave the parsing logic in place, but instead of actually updating the registry host, generate log that says we aren't in the case that we would have originally. Also, might be worth adding some log that prints their registry when creating the secret (i.e. |
…nts out the repository that the secret was created for Signed-off-by: Caroline Scherf <fcaroline@vmware.com>
Contributor
Author
|
@tomkennedy513 parsing logic is back in with additional logic to handle docker. I've also added a log that prints the secret's target registry e.g |
chenbh
reviewed
Aug 1, 2023
Signed-off-by: Caroline Scherf <fcaroline@vmware.com>
chenbh
approved these changes
Aug 2, 2023
neil-hickey
pushed a commit
to neil-hickey/kpack-cli
that referenced
this pull request
Jan 13, 2026
…/Issue-324-bug-fix-create-secret [Issue-324] Removes logic that parses registry host when using `kp cr…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eate secret --registry` flag, fixes bug that caused dockerhub registry to parse incorrectly