Fix parseInt overflow check false negative#231
Merged
buger merged 1 commit intobuger:masterfrom Jun 20, 2021
Merged
Conversation
12fee25 to
fc8b497
Compare
fc8b497 to
608d8c5
Compare
Owner
|
👌🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: The current parseInt overflow check may return false negative for input like
27670116110564327410. This patch fixes the overflow checking.Benchmark before change:
Benchmark after change:
parseInt benchmark before:
parseInt benchmark after: