Description

DynExecutor::requires_confirmation was added in PR #3649 (fix for #3646) but has no dedicated delegation unit test. All other DynExecutor delegation methods have direct tests; this gap should be closed for consistency.

Expected Behavior

A unit test verifying that DynExecutor::requires_confirmation correctly delegates to the inner ErasedToolExecutor, analogous to tests for is_tool_retryable and is_tool_speculatable.

Recommended Fix

Add to the test suite in crates/zeph-tools/src/executor.rs:

#[test]
fn dyn_executor_requires_confirmation_delegates() {
    // Create an ErasedToolExecutor impl that returns true for requires_confirmation_erased
    // Wrap it in DynExecutor
    // Assert that dyn_executor.requires_confirmation(&dummy_call()) == true
}

Environment

• Version: post-fix(build,tools): add testing to full feature; fix DynExecutor::requires_confirmation delegation #3649
• Identified during code review of PR fix(build,tools): add testing to full feature; fix DynExecutor::requires_confirmation delegation #3649