Conversation
…res_confirmation delegation Closes #3648: integration tests use zeph_llm::mock which is gated on cfg(any(test, feature = "testing")); adding "testing" to the "full" feature bundle makes clippy --all-targets --features full compile cleanly. Closes #3646: DynExecutor::requires_confirmation was missing from the ToolExecutor impl, always returning the trait default (false) instead of delegating to the inner ErasedToolExecutor, inconsistent with all other delegation methods (is_tool_retryable, is_tool_speculatable, etc.).
…o 2s The 500 ms bound is too tight for slow CI runners; the test was previously not compiled (no 'testing' in 'full') and is now exposed by #3648's fix. 2 s is still meaningful for a mock-only run with no real I/O.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"testing"to thefullfeature bundle in rootCargo.tomlsocargo clippy --all-targets --features full -- -D warningscompiles cleanly (Closes fix: cargo clippy --all-targets fails without feature=testing (zeph_llm::mock unavailable in integration tests) #3648)requires_confirmationdelegation toDynExecutor'sToolExecutorimpl incrates/zeph-tools/src/executor.rs(Closes fix(tools): DynExecutor::requires_confirmation does not delegate to inner ErasedToolExecutor #3646)Changes
Cargo.toml:testingadded tofullfeature. Thetestingfeature gates onlyzeph_llm::mockandAnyProvider::Mock— stub test infrastructure with no effect on release binaries. Without this, integration tests compiled via--all-targetscannot seeAnyProvider::Mock, producing 40 compilation errors.crates/zeph-tools/src/executor.rs:DynExecutor::requires_confirmationnow delegates toself.0.requires_confirmation_erased(call), consistent withis_tool_retryable,is_tool_speculatable,set_skill_env, andset_effective_trust. Previously the method was absent and the trait default (false) was returned, silently bypassing the inner executor's confirmation policy.Test plan
cargo +nightly fmt --check— cleancargo clippy --all-targets --features full -- -D warnings— 0 errors (primary verification for fix: cargo clippy --all-targets fails without feature=testing (zeph_llm::mock unavailable in integration tests) #3648)cargo nextest run --config-file .github/nextest.toml --workspace --lib --bins— 8919 passed, 0 failures