Fix recently discovered discrepancies with protoc#229
Merged
Conversation
…either should protocompile
…in numeric literals, allow negative nan in option values, allow case-insensitive inf, infinity, and nan in message literals
Member
Author
|
cc @jacobbuf |
Alfus
approved these changes
Dec 12, 2023
jhump
added a commit
to jhump/protoreflect
that referenced
this pull request
Dec 13, 2023
kralicky
added a commit
to kralicky/protocompile
that referenced
this pull request
Feb 7, 2024
Removes support for explicit positive sign `+` before numeric literals since that is not actually supported by `protoc`. Also adds support for `-nan` (with negative sign) in option values as well as case-insensitive `inf`, and `infinity`, and `nan` in message literals, all of which are allowed by `protoc`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes support for explicit positive sign
+before numeric literals since that is not supported byprotoc. Also adds support for-nan(with negative sign) in option values as well as case-insensitiveinf, andinfinity, andnanin message literals, all of which are allowed byprotoc.While in here, I tweaked some of the error messages for recently-added lenience to more closely resemble the syntax errors previously produced.
Fixes #223
Fixes #225