Fix name of protoc_gen_star_v2 repo#900
Merged
rodaine merged 2 commits intobufbuild:mainfrom Jun 23, 2023
Merged
Conversation
Contributor
Author
|
@pdecks, @elliotmjackson or @rodaine do you mind taking a look? |
rodaine
approved these changes
Jun 23, 2023
Contributor
Author
|
@rodaine Could you please cut a new minor release that includes this fix? Would it be a lot of work? |
Member
htuch
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Dec 11, 2023
Similar to bufbuild/protoc-gen-validate#900 correct naming should include the major version. https://go.dev/ref/mod#module-path If the module is released at major version 2 or higher, the module path must end with a major version suffix like /v2. This may or may not be part of the subdirectory name. For example, the module with path golang.org/x/repo/sub/v2 could be in the /sub or /sub/v2 subdirectory of the repository golang.org/x/repo. So go_repository stanza also should include the major version, to distinguish between the different major versions of the module, that can coexist. Signed-off-by: Alex Bozhenko <abozhenko@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this project is used in a repo that uses Gazelle, the build fails with the following error:
#535 (comment)
That error was introduced when protoc_gen_star was updated to v2 in #783
and
dependencies.bzlwas (I believe) manually updated.Should gazelle be used to update
dependencies.bzl, it would choosecom_github_lyft_protoc_gen_star_v2as a name for the repo, as I showed here:alexbozhenko#1
This PR updates all references to that repo to use the correct name, which is expected by Gazelle.
PR was created with: