Add manifest digest field to repo commit#1877
Merged
unmultimedio merged 2 commits intomainfrom Mar 3, 2023
Merged
Conversation
pkwarren
reviewed
Mar 2, 2023
| // presented or cannot be classified into a known license. | ||
| string spdx_license_id = 10; | ||
| // The manifest digest of the commit. Populated via Tamper Proofing. | ||
| string manifest_digest = 11; |
Member
There was a problem hiding this comment.
We should go ahead and mark digest as deprecated and we also will want to update module_resolver.go to use the manifest_digest as the digest when creating the ModulePin instead of the digest.
Member
Author
There was a problem hiding this comment.
About the deprecation, I prefer to do that at the same time we mark as deprecated the old Push/Download rpcs. For now since everything is backwards compatible, no need for that additional warning.
For the module_resolver and other CLI code changes let's do in an upcoming PR? I'd like this to be schema change only.
pkwarren
approved these changes
Mar 3, 2023
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
Represent new manifest digest content in a new proto field for repository commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Represent new manifest digest content in a new proto field for repository commits.