Merged
Conversation
pkwarren
reviewed
Dec 9, 2022
Member
pkwarren
left a comment
There was a problem hiding this comment.
Changes look good - verified locally with v2 plugins and buf.gen.yaml.
| return responseSet, nil | ||
| } | ||
|
|
||
| func getPluginGenerationRequest( |
Member
There was a problem hiding this comment.
Thanks for refactoring these out.
pkwarren
approved these changes
Dec 9, 2022
Member
pkwarren
left a comment
There was a problem hiding this comment.
Changes look good to me. This feels like something we should highlight in the changelog for next release.
srikrsna-buf
commented
Dec 9, 2022
pkwarren
reviewed
Dec 9, 2022
pkwarren
approved these changes
Dec 9, 2022
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
Closes TCN-823.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes TCN-823.