TCN-858 explicitly define upload assets#1657
Merged
elliotmjackson merged 3 commits intomainfrom Dec 7, 2022
Merged
Conversation
pkwarren
reviewed
Dec 7, 2022
pkwarren
approved these changes
Dec 7, 2022
pkwarren
reviewed
Dec 7, 2022
.github/workflows/release.yaml
Outdated
| ${{env.ASSETS_PATH}}/protoc-gen-buf-lint-Windows-arm64.exe | ||
| ${{env.ASSETS_PATH}}/protoc-gen-buf-lint-Windows-x86_64.exe | ||
| ${{env.ASSETS_PATH}}/sha256.txt | ||
| ${{env.ASSETS_PATH}}/sha256.txt.minisig |
Member
There was a problem hiding this comment.
It looks like the action supports glob style path patterns, so we might be able to do:
files: ${{env.ASSETS_PATH}}/*See https://github.com/softprops/action-gh-release/blob/9114792eb2fcdea3dbb139ffd081fcb856870dcf/src/util.ts#L76-L82 for more details.
Contributor
Author
There was a problem hiding this comment.
1 second... will try
Contributor
Author
There was a problem hiding this comment.
potentially the definition of overthinking it. resolved in d4e3f0d
elliotmjackson
commented
Dec 7, 2022
elliotmjackson
commented
Dec 7, 2022
pkwarren
approved these changes
Dec 7, 2022
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
To determine the files to be uploaded, pipe the result of a find command into en env var, id only tested it on a single file in the past - when it has multiple files, it finds a new line character and terminates. as such, release fails to upload assets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To determine the files to be uploaded, pipe the result of a find command into en env var, id only tested it on a single file in the past - when it has multiple files, it finds a new line character and terminates.
as such, release fails to upload assets.
To move forward, im explicitly defining the upload assets so the release process can continue. Naturally a more elegant solution would be preferable but i think this still falls into the "win" category