BSR-704/default except override for optimize_for#1625
Merged
oliversun09 merged 20 commits intomainfrom Dec 12, 2022
Merged
Conversation
…add a testing helper
doriable
reviewed
Dec 8, 2022
private/buf/bufgen/generator.go
Outdated
| sweeper, | ||
| *managedConfig.OptimizeFor, | ||
| managedConfig.OptimizeForConfig.Default, | ||
| managedConfig.JavaPackagePrefix.Except, |
Member
There was a problem hiding this comment.
This should be OptimizeForConfig.Except.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this!
doriable
approved these changes
Dec 8, 2022
Member
doriable
left a comment
There was a problem hiding this comment.
Looks good -- will need to fix the merge conflict in the changelog, since a release went out recently, but otherwise it seems fine. Thanks!
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
* Add default, except override to managed mode `optimize_for` option * preserves backward compatibility with the current `optimize_for` option being string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimize_foroptionoptimize_foroption being string