Make sure that message notifications marked as read are in the current thread.#14
Closed
adiloztaser wants to merge 3 commits intobuddypress:masterfrom
Closed
Make sure that message notifications marked as read are in the current thread.#14adiloztaser wants to merge 3 commits intobuddypress:masterfrom
adiloztaser wants to merge 3 commits intobuddypress:masterfrom
Conversation
…e current thread." This reverts commit 5eb7c6c.
thebrandonallen
pushed a commit
to thebrandonallen/buddypress
that referenced
this pull request
Apr 14, 2022
When viewing the single view of the thread, the potential notifications about it are marked as read into the `messages_action_conversation()` function. We don't need to do it again when looping into the thread messages. This was revealed by a database error which was appearing when a user who had received more than 1 message from two different threads was directly viewing the single view of one of the threads. Props mike80222, oztaser Closes buddypress/buddypress#14 See #8676 (trunk) git-svn-id: https://buddypress.svn.wordpress.org/trunk@13269 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
May 23, 2022
When viewing the single view of the thread, the potential notifications about it are marked as read into the `messages_action_conversation()` function. We don't need to do it again when looping into the thread messages. This was revealed by a database error which was appearing when a user who had received more than 1 message from two different threads was directly viewing the single view of one of the threads. Props mike80222, oztaser Closes buddypress/buddypress#14 See #8676 (trunk) git-svn-id: http://buddypress.svn.wordpress.org/trunk@13269 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
emaralive
pushed a commit
to emaralive/omt-buddypress-sync
that referenced
this pull request
Nov 2, 2025
When viewing the single view of the thread, the potential notifications about it are marked as read into the `messages_action_conversation()` function. We don't need to do it again when looping into the thread messages. This was revealed by a database error which was appearing when a user who had received more than 1 message from two different threads was directly viewing the single view of one of the threads. Props mike80222, oztaser Closes buddypress/buddypress#14 See #8676 (trunk) git-svn-id: https://buddypress.svn.wordpress.org/trunk@13269 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
emaralive
pushed a commit
to emaralive/buddypress-sync
that referenced
this pull request
Nov 3, 2025
When viewing the single view of the thread, the potential notifications about it are marked as read into the `messages_action_conversation()` function. We don't need to do it again when looping into the thread messages. This was revealed by a database error which was appearing when a user who had received more than 1 message from two different threads was directly viewing the single view of one of the threads. Props mike80222, oztaser Closes buddypress/buddypress#14 See #8676 (trunk) git-svn-id: https://buddypress.svn.wordpress.org/trunk@13269 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://buddypress.trac.wordpress.org/ticket/8676
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.