🤖 Claude Code Review

Status: Complete

This PR reverts PR #514 which implemented BIP68 relative locktime validation. The revert is clean and comprehensive.

Analysis:

This is a straightforward revert of BIP68 functionality due to reported performance degradation during legacy sync. The changes are consistent and complete:

• Removes MedianTimePast field from BlockHeaderMeta struct and serialization
• Removes GetMedianTimePastForHeights method from blockchain client/interface
• Removes BIP68 sequence validation logic from transaction validator
• Removes all BIP68-related tests (559+ lines in validator, 866+ lines in e2e)
• Removes median time past calculation helper functions
• Updates protobuf definitions to remove MTP-related messages
• Removes BIP68 test from Makefile legacy-sync target

No Issues Found

The revert appears complete and safe:

• No database migration needed (MTP was never stored in DB, only in-memory)
• Binary serialization format correctly adjusted (capacity calculation reduced by 4 bytes)
• All references to BIP68 and MTP functionality removed
• Test suite updated to exclude BIP68 tests
• No orphaned code or incomplete removals detected

The performance issue mentioned in the PR description justifies the temporary revert while a more efficient implementation is developed.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud