Disable go-metrics for Kafka to prevent memory leak#51
Merged
oskarszoon merged 2 commits intoOct 24, 2025
Conversation
ordishs
approved these changes
Oct 24, 2025
Contributor
|
🤖 Claude Code Review Status: Complete Current Review:
The fix prevents the known Sarama memory leak from exponential decay sample heap growth. Test files use sarama.NewConfig() but don't need this fix as they create short-lived test instances. History:
|
|
torrejonv
pushed a commit
to torrejonv/teranode
that referenced
this pull request
Oct 26, 2025
ordishs
added a commit
to ordishs/teranode
that referenced
this pull request
Jan 12, 2026
Document that /api/v1/blocks/:hash?n=3 returns all blocks but concatenated: - Binary format has no delimiters between blocks - All requested blocks are present in the response - Clients must parse blocks sequentially using block format spec - Browser downloads may appear to show only first block - Recommend using /json endpoint for easier inspection - Add detailed parsing steps for binary format Addresses issue bsv-blockchain#51 from teranode-review
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.