Skip to content

Fix CI builds not running on PRs#642

Merged
asgrim merged 1 commit into7.3.xfrom
fix-builds-not-running
Nov 21, 2023
Merged

Fix CI builds not running on PRs#642
asgrim merged 1 commit into7.3.xfrom
fix-builds-not-running

Conversation

@asgrim
Copy link
Copy Markdown
Member

@asgrim asgrim commented Nov 21, 2023

I noticed in #640 and #641 the builds are not running. I think this should fix it, it seems it was changed in #528 but not really sure why, but I think that may have broken it

@asgrim asgrim added the bug label Nov 21, 2023
@asgrim asgrim added this to the 7.3.0 milestone Nov 21, 2023
@asgrim asgrim requested a review from mimmi20 November 21, 2023 10:09
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c793aaa) 36.26% compared to head (d630b78) 36.26%.

Additional details and impacted files
@@            Coverage Diff            @@
##              7.3.x     #642   +/-   ##
=========================================
  Coverage     36.26%   36.26%           
  Complexity      286      286           
=========================================
  Files            27       27           
  Lines          1183     1183           
=========================================
  Hits            429      429           
  Misses          754      754           
Flag Coverage Δ
phpunit 36.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asgrim asgrim merged commit 3496329 into 7.3.x Nov 21, 2023
@asgrim asgrim deleted the fix-builds-not-running branch November 21, 2023 10:53
@asgrim asgrim mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants