Merged
Conversation
mimmi20
requested changes
Nov 21, 2023
Member
mimmi20
left a comment
There was a problem hiding this comment.
Please add experimental support for PHP 8.4
Member
|
Hmm not sure why the build hasn't run here, it's not asking to approve the pipeline either? |
Contributor
Author
|
Fun fact: the build had a successful run on my fork https://github.com/Slamdunk/browscap-php/actions/runs/6941392168 |
mimmi20
approved these changes
Nov 21, 2023
3 tasks
Member
asgrim
approved these changes
Nov 21, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.3.x #640 +/- ##
=========================================
Coverage 36.26% 36.26%
Complexity 286 286
=========================================
Files 27 27
Lines 1183 1183
=========================================
Hits 429 429
Misses 754 754
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
@Slamdunk thank you - this all green now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.