Skip to content

[BC Break] Add support for Symfony 6 (from @Slamdunk)#418

Merged
asgrim merged 3 commits into7.0.xfrom
Slamdunk-symfony_6
Feb 23, 2022
Merged

[BC Break] Add support for Symfony 6 (from @Slamdunk)#418
asgrim merged 3 commits into7.0.xfrom
Slamdunk-symfony_6

Conversation

@asgrim
Copy link
Copy Markdown
Member

@asgrim asgrim commented Feb 23, 2022 •
edited
Loading

Fixes #416 #413

The isolated BC breaks in this PR are as follows:

 - [BC] BrowscapPHP\Command\UpdateCommand was marked "@internal"
 - [BC] BrowscapPHP\Command\FetchCommand was marked "@internal"
 - [BC] BrowscapPHP\Command\ConvertCommand was marked "@internal"
 - [BC] BrowscapPHP\Command\CheckUpdateCommand was marked "@internal"
 - [BC] BrowscapPHP\Command\ParserCommand was marked "@internal"
 - [BC] BrowscapPHP\Helper\Filesystem was marked "@internal"

These BC breaks are necessary to prevent upstream Symfony BC breaks leaking into our own API. I did NOT mark these classes as final (although ideally they should be, perhaps we can do that in a future release), but this means we will no longer support BC in any of these classes. Downstream consumers should not extend these @internal classes any more, and will receive an error if they are extending them in turn and using Roave/BackwardsCompatibilityCheck.

@asgrim asgrim added this to the 6.2.0 milestone Feb 23, 2022
@asgrim asgrim self-assigned this Feb 23, 2022
@asgrim asgrim mentioned this pull request Feb 23, 2022
Closed
asgrim
asgrim commented Feb 23, 2022
View reviewed changes
@asgrim asgrim mentioned this pull request Feb 23, 2022
Closed
@asgrim
Mark all extensions from Symfony components as @internal as we cannot…
7a62648 
… guarantee against upstream BC breaks when supporting multiple Symfony major versions
@asgrim asgrim modified the milestones: 6.2.0, 7.0.0 Feb 23, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 23, 2022 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.64%. Comparing base (af6d7b0) to head (7a62648).
⚠️ Report is 4 commits behind head on 7.0.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##              7.0.x     #418      +/-   ##
============================================
- Coverage     39.28%   37.64%   -1.64%     
  Complexity      283      283              
============================================
  Files            27       27              
  Lines           919      842      -77     
============================================
- Hits            361      317      -44     
+ Misses          558      525      -33
Flag Coverage Δ
7.4 37.64% <ø> (-1.64%) ⬇️
php-7.4 37.64% <ø> (-1.64%) ⬇️
phpunit 37.64% <ø> (-1.64%) ⬇️
ubuntu-20.04 37.64% <ø> (-1.64%) ⬇️
xdebug 37.64% <ø> (-1.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asgrim asgrim changed the title Slamdunk symfony 6 Add support for Symfony 6 (from @Slamdunk) Feb 23, 2022
@asgrim asgrim changed the base branch from 6.2.x to 7.0.x February 23, 2022 09:13
@asgrim asgrim changed the title Add support for Symfony 6 (from @Slamdunk) [BC Break] Add support for Symfony 6 (from @Slamdunk) Feb 23, 2022
@asgrim asgrim merged commit 81f1ff4 into 7.0.x Feb 23, 2022
@asgrim asgrim deleted the Slamdunk-symfony_6 branch February 23, 2022 09:15
@j-dobr j-dobr mentioned this pull request Sep 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@asgrim asgrim

Labels

BC break enhancement

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

Update symfony/console to 6.x.

3 participants

@asgrim @codecov-commenter @Slamdunk