Skip to content

Allow Symfony 6#413

Closed
Slamdunk wants to merge 1 commit intobrowscap:6.2.xfrom
Slamdunk:symfony_6
Closed

Allow Symfony 6#413
Slamdunk wants to merge 1 commit intobrowscap:6.2.xfrom
Slamdunk:symfony_6

Conversation

@Slamdunk
Copy link
Copy Markdown
Contributor

@Slamdunk Slamdunk commented Jan 26, 2022

Fixes #416

@mimmi20 mimmi20 requested a review from asgrim January 26, 2022 07:39
@Slamdunk
Copy link
Copy Markdown
Contributor Author

Regarding the BC Break reported by CI: I think BrowscapPHP\Helper\Filesystem should be @internal

@Slamdunk
Copy link
Copy Markdown
Contributor Author

Ping @asgrim

@asgrim
Copy link
Copy Markdown
Member

asgrim commented Feb 23, 2022

@Slamdunk thanks - we'll take this further upstream, even latest BCC tool falters here, I can't think why at the moment (see also #418 )

@asgrim
Copy link
Copy Markdown
Member

asgrim commented Feb 23, 2022

Yeah, BC breaks are correct here, because we use extends for both Symfony Commands and Filesystem as you found, then upstream BC breaks are also our own inherited BC breaks. I'm closing this in favour of #418 where a BC break here is necessary to make our own classes @internal to avoid this going forward. Thank you!

@asgrim asgrim closed this Feb 23, 2022
@Slamdunk Slamdunk deleted the symfony_6 branch February 23, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update symfony/console to 6.x.

3 participants