Skip to content

Use WebAsset for counter#98

Merged
brianteeman merged 2 commits intobrianteeman:counter2from
Fedik:pull27804-asset
Feb 6, 2020
Merged

Use WebAsset for counter#98
brianteeman merged 2 commits intobrianteeman:counter2from
Fedik:pull27804-asset

Conversation

@Fedik
Copy link
Copy Markdown

@Fedik Fedik commented Feb 6, 2020

This is for joomla#27804

@brianteeman
Copy link
Copy Markdown
Owner

Thank you very much. Looking at your changes to the init script it is no wonder I coukdnt get it to work ;)

Merging

@brianteeman brianteeman merged commit ac9b402 into brianteeman:counter2 Feb 6, 2020
@Fedik
Copy link
Copy Markdown
Author

Fedik commented Feb 6, 2020

there was a little issue that init.js ignores attributes from setting.json

@Fedik Fedik deleted the pull27804-asset branch February 6, 2020 09:44
@brianteeman
Copy link
Copy Markdown
Owner

and I thought it was me not writing it correctly ;)

brianteeman pushed a commit that referenced this pull request May 26, 2020
brianteeman pushed a commit that referenced this pull request Dec 4, 2020
- Remove display:grid for top and bottom positions -> improve display for mod_news on top-a
- Move rtl definition for footer to _footer.scss ([dir=rtl] & )
- Add margin to form control-group - #92
- Add underline for links without class (e.g. in text) -> #98
- Improve underline rules for links on menus -> #97
- Change padding and position for mod-list on sidebar
- Improve links in mod-menu on sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants