Merged
Conversation
Owner
That was my view of my own code
Can you give me an example of where we have that |
Author
|
Nothing I'm aware of in core. It seems relatively unlikely because we'd always be hiding the label. But before we did handle it and now we don't |
Owner
|
Thanks @wilsonge |
brianteeman
pushed a commit
that referenced
this pull request
May 26, 2020
* Add codeowners * Rename transition tab options to actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes code and prevents the double
control-groupstuff.However comes with different issues on the permissions fields:
My PR has the issue that it fixes that but effectively reintroduces the
controlsclass which means the permissions field is shifted left. So I gave it it's own classrevert-permissionsand overriding themargin-left. Not convinced it's amazing but it works :/