Closed
Conversation
brianc
added a commit
that referenced
this pull request
Aug 19, 2022
* Add check for valid parameter array This fixes the issue outlined in #84 by preventing non-array values being passed into C/C++ binding from the JS layer. Will modify node-pg-native & node-postgres individually to bump versions for this fix. Also fixes memory leak from #77 * Add CI workflow to github * Add postgres to ci * Add logging to error so I can see whats going on in the githubs * Use pretest so env vars go to test cmd * Add host to cmd * Run prettier with quote rule matching existing code for fewer changes * Prettier that too
Owner
|
This has been fixed - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a memory leak in the latest release.
Tested:
NodeJS v10.18.1, libpq 1.8.8 - No memory leak
NodeJS v10.18.1, libpq 1.8.9 - There is a memory leak
NodeJS v12.16.3, libpq 1.8.9 - There is a memory leak
I consulted the documentation and reference tests (https://github.com/nodejs/nan/blob/2c4ee8a32a299eada3cd6e468bbd0a473bfea96d/test/cpp/weak.cpp#L23
) and tried to fix.