Documentation and code clarification.#3
Merged
bramd merged 2 commits intoMay 20, 2019
Conversation
Author
|
I'd really like to get this merged nvaccess#8853 merged in. But first I would like either @bramd or @LeonarddeR to take a look. Please could one of you take a look at this? |
LeonarddeR
approved these changes
May 14, 2019
LeonarddeR
left a comment
There was a problem hiding this comment.
I would personally advice to have @bramd or someone else with a display have one additional round of testing.
Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
Owner
|
@feerrenrut Thanks for your work, looks good to me. I'll give this one more round of testing with the display I have. |
Owner
|
Everything still works as expected with the Focus 40 blue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some suggestions for PR nvaccess#8853