increase espeak speed to maximum without sonic#603
Merged
Conversation
Collaborator
|
It seems espeak as well caps to 450: so yes we can increase to 449 in both case. Why not setting 450, though? |
Contributor
Author
because of espeak-ng/espeak-ng#131 |
Collaborator
ok :) |
5 tasks
seanbudd
pushed a commit
to nvaccess/nvda
that referenced
this pull request
Jul 14, 2022
…d. (#13893) A partial fix for issue #13876. Summary of the issue: With eSpeak, when rate boost is off, the speech rate is slightly higher (7% according to espeak-ng/espeak-ng#131 (comment)) when rate is 99% than when rate is 100%. Description of user facing changes With eSpeak, a speech rate of 100% corresponds to the fastest speech rate without rate boost; no more rate drop between 99% and 100% Description of development approach `_espeak.maxRate` is the rate used when NVDA speech rate is 100%. So set `_espeak.maxRate` to 449 instead of 450. Indeed according to espeak-ng/espeak-ng#131: * the sonic library is used for eSpeak rate set to 450 or higher for many years (instead of 451 before). * other ATs may already be using this new value, e.g. speech-dispatcher: https://github.com/brailcom/speechd (cf. brailcom/speechd#603) This allows to have a continuous increasing of speech rate when rate boost is off and to reserve the use of the sonic library for rate boost on. If one day, eSpeak turns back to 450 for maxRate (what seems unlikely), we may revert this PR's content to follow eSpeak's decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if I need to change the espeak config I only tested espeak-ng
maybe we should increase the minimum and average speed too.