Skip to content

Fix storyboard constraints so textViews are responsive, fixes #30#32

Merged
keith merged 1 commit intobr1sk:masterfrom
jessesquires:master
Apr 14, 2017
Merged

Fix storyboard constraints so textViews are responsive, fixes #30#32
keith merged 1 commit intobr1sk:masterfrom
jessesquires:master

Conversation

@jessesquires
Copy link
Copy Markdown
Contributor

@jessesquires jessesquires commented Apr 14, 2017

If you download the 0.1.0 release and run the app, the text views aren't responsive.

Confirmed that NSTextViewDelegate methods are getting called, but views were not updating.

Seems to be an issue with layout constraints. This isn't a perfect fix, but it works. Text views are now responsive.

Issues:
The "description" text view doesn't resize it's height like the others when resizing the window. Not sure how to fix this.

Fixes #30.

@jessesquires
Copy link
Copy Markdown
Contributor Author

jessesquires commented Apr 14, 2017

Also, this may just be treating a symptom of a larger issue. Open to any other ideas/feedback here 😄

@keith
Copy link
Copy Markdown
Member

keith commented Apr 14, 2017

This does end up breaking the current resizing behavior. Note that the top next field size is not the same as the others:

image

@keith
Copy link
Copy Markdown
Member

keith commented Apr 14, 2017

I'm going to merge this for now anyways because it's way worse to not be able to type 🙃

@keith keith merged commit 90b3822 into br1sk:master Apr 14, 2017
@keith
Copy link
Copy Markdown
Member

keith commented Apr 14, 2017

Thanks for fixing this! I'm still very confused at why this doesn't happen for all users 🤔

@keith
Copy link
Copy Markdown
Member

keith commented Apr 14, 2017

I've just pushed 0.1.1 with only this fix. https://github.com/br1sk/brisk/releases/tag/0.1.1 Thanks again!

@keith
Copy link
Copy Markdown
Member

keith commented Apr 14, 2017

Filed #33 for the resizing thing

@jessesquires
Copy link
Copy Markdown
Contributor Author

thanks @keith !

Yeah -- I'm not sure how to fix the vertical sizing -- I'm not super familiar with StackView.

@saagarjha
Copy link
Copy Markdown
Contributor

saagarjha commented Apr 15, 2017

I have an alternate solution that I believe is "cleaner" IMHO (at least, it resizes correctly unlike #33); it just calls the window's setContentSize(_:) in viewWillAppear(), which seems to resolve the issue. Should I revert this and open a pull request?

EDIT: It's available here if you want to try it out.

saagarjha added a commit to saagarjha/brisk that referenced this pull request Apr 15, 2017
This reverts commit 90b3822, reversing
changes made to b574e33.
@keith
Copy link
Copy Markdown
Member

keith commented Apr 16, 2017

I think @Reflejo is working on something that would also fix this a different way right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text areas do not redraw themselves

3 participants