Skip to content

Workaround for #30, #33#120

Merged
keith merged 1 commit intobr1sk:masterfrom
saagarjha:master
Aug 26, 2017
Merged

Workaround for #30, #33#120
keith merged 1 commit intobr1sk:masterfrom
saagarjha:master

Conversation

@saagarjha
Copy link
Copy Markdown
Contributor

This is a hack to fix #30 and #33 until Apple fixes rdar://problem/34061891.

@keith
Copy link
Copy Markdown
Member

keith commented Aug 24, 2017

Thanks for submitting this! I don't see any negative effects so it should be good to go. But first can you remove the update pods commit, I don't want to be on a beta CP version, and also can you fix the indention of the code and comment here? It seems to be a bit off. Thanks!

@saagarjha
Copy link
Copy Markdown
Contributor Author

Sure thing.

@keith
Copy link
Copy Markdown
Member

keith commented Aug 24, 2017

Nice thanks! I'll merge it when it's green!

@saagarjha
Copy link
Copy Markdown
Contributor Author

@keith I've fixed the formatting issues. Is there anything else you'd like me to do?

@keith keith merged commit 129c482 into br1sk:master Aug 26, 2017
@keith
Copy link
Copy Markdown
Member

keith commented Aug 26, 2017

Nope sorry, it just took a long time for travis to run

keith added a commit that referenced this pull request Aug 26, 2017
@keith keith added this to the 1.1.2 milestone Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text areas do not redraw themselves

2 participants