Merged
Conversation
89363fc to
97f24ec
Compare
sberrevoets
reviewed
Jul 30, 2017
| self.reproducibilityPopUp.setItems(titles: Reproducibility.All.map { $0.name }) | ||
| self.productPopUp.set(items: Product.All, getTitle: { $0.name }, getGroup: { $0.category }) | ||
| self.attachmentDroppableView.droppedAttachment = { [weak self] attachments in | ||
| self?.attachments = [attachments] |
Contributor
There was a problem hiding this comment.
Should this be overridden or appended? I get we don't really support multiple attachments now, but if there's UI for this in the future I think adding makes more sense here than replacing?
Member
Author
There was a problem hiding this comment.
Right now since we're not supporting multiple attachments this is a replacement. Eventually it will definitely be an append but it gets weird with the current UI since you don't know what you have attached, and removing removes all of them.
sberrevoets
reviewed
Jul 30, 2017
|
|
||
| fileprivate extension NSDraggingInfo { | ||
| private var files: [String]? { | ||
| return self.draggingPasteboard().propertyList(forType: NSFilenamesPboardType) as? [String] |
Contributor
There was a problem hiding this comment.
Is the meaning between nil and an empty array here different? If not, I'd ?? [].
sberrevoets
approved these changes
Jul 30, 2017
d35b981 to
546a4b1
Compare
This allows you to drag and drop a single attachment onto the bottom of the new radar UI
546a4b1 to
7af2a89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows you to drag and drop a single attachment onto the bottom of
the new radar UI
This supersedes #102 and fixes #35