Skip to content

Adds drag-'n-drop support for a single attachment#102

Closed
AndreasVerhoeven wants to merge 3 commits intobr1sk:masterfrom
AndreasVerhoeven:master
Closed

Adds drag-'n-drop support for a single attachment#102
AndreasVerhoeven wants to merge 3 commits intobr1sk:masterfrom
AndreasVerhoeven:master

Conversation

@AndreasVerhoeven
Copy link
Copy Markdown

Not very fancy, but fixes a small annoyance I had by adding simple drag-'n-drop (great tool btw!)

ezgif-2-24fb8ab77d

@ZevEisenberg
Copy link
Copy Markdown
Contributor

It would be nice if there were some visual indication to let the user know that they can drag in a file, but this is awesome!

@AndreasVerhoeven
Copy link
Copy Markdown
Author

@ZevEisenberg agreed - that would require some rework on the UI I think. I think it makes sense to directly add support for multiple attachments as well. I would be fine doing that, if there are some suggestions for the UI :)

@unnamedd
Copy link
Copy Markdown

unnamedd commented Jul 24, 2017

If I could suggest something related to UI for these issue... #17

@keith
Copy link
Copy Markdown
Member

keith commented Jul 30, 2017

Awesome, thanks for submitting this @AndreasVerhoeven ! I've changed the droppable class a bit to have a bit more of the responsibility and submitted #109 so I'm going to close this one.

I think this UI is a good start for now, and we need multiple attachment UI before we do much more with it. Right now this code should be extensible to multiple attachments, we just need to figure out the UI piece before we support that.

@keith keith closed this Jul 30, 2017
@keith keith modified the milestone: 1.1.0 Jul 30, 2017
@keith
Copy link
Copy Markdown
Member

keith commented Jul 30, 2017

Released in 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants