Updating RcppArmadillo initialization#3
Merged
bpfaff merged 1 commit intobpfaff:masterfrom Sep 6, 2022
Merged
Conversation
These six one-line changes update RcppArmadillo from the now deprecated `<<` initialization to brace initialization allowed since C++11 and long been the minimal standard with R too. It would be great if you could merge this, and release and updated package "in the next little while" -- see the two prior emails I sent, and the transition log at RcppCore/RcppArmadillo#391
Closed
31 tasks
Owner
|
Lieber Dirk,
das mache ich selbstverständlich gerne und Deine vorherigen Emails sind ebenfalls registriert. Bisher habe ich noch keine Zeit hierfür gefunden. Am Dienstag sollte es klappen. Vielen lieben Dank für den friendly reminder.
Liebe Grüße nach Chicago,
Bernhard
*Von: *Dirk Eddelbuettel ***@***.***>
*An: *bpfaff/cccp ***@***.***>
*Kopie: *Subscribed ***@***.***>
*Datum: *05.09.2022 00:47:30
*Betreff: *[bpfaff/cccp] Updating RcppArmadillo initialization (PR #3)
Lieber Bernhard,
These six one-line changes update RcppArmadillo from the now
deprecated *<<* initialization to brace initialization allowed since
C++11 and long been the minimal standard with R too. It would be
great if you could merge this, and release and updated package "in the
next little while" -- see the two prior emails I sent, and the
transition log at RcppCore/RcppArmadillo#391[RcppCore/RcppArmadillo#391]
Oh, and tested with CRAN 0.2-7 and GitHub 0.2-8.
Gruesse und Tschoe, Dirk
----------------------------------------
*You can view, comment on, or merge this pull request online at:*
#3
*Commit Summary*
*File Changes*
(6 files[https://github.com/bpfaff/cccp/pull/3/files])
* > *M* src/DCP.cpp[https://github.com/bpfaff/cccp/pull/3/files#diff-65cb1556d3949ed394e844a15806d42bdb879ae8e854d5f5b5e7d6e3a7621927] (2)
* > *M* src/DLP.cpp[https://github.com/bpfaff/cccp/pull/3/files#diff-d62e5560e09a431701dd0a2c56218d30e9171d75d7b594f587b08b322fff6b3f] (2)
* > *M* src/DNL.cpp[https://github.com/bpfaff/cccp/pull/3/files#diff-d26ab7bc25ecdf7d51c66e8ccba845eb854bc24220634e8f74bfb5561cf944d1] (2)
* > *M* src/DQP.cpp[https://github.com/bpfaff/cccp/pull/3/files#diff-dfe29b9409d796c693131609be7192d168ed39965fb1c69772bb85b893adbd83] (2)
* > *M* src/GPP.cpp[https://github.com/bpfaff/cccp/pull/3/files#diff-00c564616dff864931e260b3bb5f38647b4b6bed596d79c9b52e2d7a24f8b913] (2)
* > *M* src/RPP.cpp[https://github.com/bpfaff/cccp/pull/3/files#diff-c7852694fbdd87143abdf114434c5e3df24903b5529d23c16b1e59371a14c479] (2)
*Patch Links:*
…
—
Reply to this email directly, view it on GitHub[#3], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ACM4F4CVO64WNUX6IIB3ZJTV4URB7ANCNFSM6AAAAAAQEQLOEU].
You are receiving this because you are subscribed to this thread.[Verfolgungsbild][https://github.com/notifications/beacon/ACM4F4BY5GCICLQTLNGQ2M3V4URB7A5CNFSM6AAAAAAQEQLOEWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFCI22LE.gif]
|
bpfaff
approved these changes
Sep 6, 2022
Owner
|
Thank you so much, Dirk. An update to CRAN will be committed in due course. Best wishes, Bernhard |
Contributor
Author
|
Excellent. As you see over on the linked issue, it is not super urgen -- some are already there but other will take time. So fold it any updated you might have done any in the next little while. Of course, "done is done" so there is always something to be said to just getting TODOs out of the way... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lieber Bernhard,
These six one-line changes update RcppArmadillo from the now
deprecated
<<initialization to brace initialization allowed sinceC++11 and long been the minimal standard with R too. It would be
great if you could merge this, and release and updated package "in the
next little while" -- see the two prior emails I sent, and the
transition log at RcppCore/RcppArmadillo#391
Oh, and tested with CRAN 0.2-7 and GitHub 0.2-8.
Gruesse und Tschoe, Dirk