fix(otel-collector): unblock Docker build after #730 apps/ normalization by G4614 · Pull Request #745 · boxlite-ai/boxlite

G4614 · 2026-06-12T10:07:38Z

Summary

Two commits restore apps/otel-collector Docker build, broken since #730 normalized the monorepo into apps/:

16873628 add python3/make/g++ to build stage — node:alpine base lacks build toolchain; cpu-features@0.0.10 (transitive yarn workspace native add-on) fails to compile during yarn install --immutable.
385c404a fix builder-config paths — apps/otel-collector/builder-config.yaml still references pre-apps/ paths:
- path: otel-collector/exporter → apps/otel-collector/exporter
- replaces: ../../../api-client-go → ../../../apps/api-client-go (and same for common-go)

Without these, OpenTelemetry collector builder errors with:

Error: invalid module configuration: filepath does not exist: /boxlite/otel-collector/exporter

Background

Split out from PR #724's CI iteration. PR #724 added a generic deploy-app-services workflow exercising Proxy / OtelCollector / SshGateway builds; Proxy + SshGateway built+deployed cleanly, OtelCollector hit these two pre-existing bugs. Fix kept on a dedicated branch so #724 stays scoped to CI automation.

Test plan

CI builds the OtelCollector Docker image without erroring at cpu-features build
OpenTelemetry collector builder resolves `path:` + `replaces:` correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

Chores
- Ensure native add-ons compile during build by installing required toolchain components and updating local build paths for collector-related builds.
Bug Fixes
- API schema defaults for assigned role IDs on organization invitations and member access updates now use empty arrays instead of placeholder values.

…pm add-ons (cpu-features)

…norepo layout (#730)

coderabbitai · 2026-06-12T10:07:53Z

📝 Walkthrough

Walkthrough

Adds native build toolchain to the otel-collector Docker build stage, updates builder-config.yaml paths to the apps/ layout, and changes two OpenAPI schema defaults for assignedRoleIds to empty arrays.

Changes

OTel Collector Build Configuration

Layer / File(s)	Summary
Docker build dependencies `apps/otel-collector/Dockerfile`	Installs `python3`, `make`, and `g++` in the Node build stage to support native add-on compilation during `yarn install`.
Go module path corrections `apps/otel-collector/builder-config.yaml`	Updates exporter source path to `apps/otel-collector/exporter` and changes `replaces` mappings to `../../../apps/api-client-go` and `../../../apps/common-go`.

API client OpenAPI defaults

Layer / File(s)	Summary
assignedRoleIds defaults `apps/api-client-go/api/openapi.yaml`	Sets `assignedRoleIds` default to `[]` in `UpdateOrganizationMemberAccess` and `CreateOrganizationInvitation` schemas.

🎯 3 (Moderate) | ⏱️ ~20 minutes

🐰 The builder hops, tools in tow,

python, make, and g++ in a row,
Paths aligned to apps/ with care,
Schemas start empty — tidy and fair,
A tiny hop forward, code light as air.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: fixing the otel-collector Docker build by addressing path normalization issues from PR `#730`.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/otel-collector-build

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/api-client-go/api/openapi.yaml`:
- Line 9568: Constructors NewUpdateOrganizationMemberAccessWithDefaults and
NewCreateOrganizationInvitationWithDefaults leave AssignedRoleIds as nil which
causes ToMap()/MarshalJSON() to emit null instead of the OpenAPI default [];
update these constructors (and any similar factory funcs referenced around the
other occurrence) to initialize AssignedRoleIds to an empty slice (e.g.,
make([]Type, 0)) so the generated ToMap()/MarshalJSON() serializes
assignedRoleIds as [] and matches the OpenAPI default; reference
AssignedRoleIds, NewUpdateOrganizationMemberAccessWithDefaults,
NewCreateOrganizationInvitationWithDefaults, and ToMap()/MarshalJSON() when
making the change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cdb481ed-7798-4402-af2c-337fba48b1cd

📥 Commits

Reviewing files that changed from the base of the PR and between 385c404 and 3b12c3a.

📒 Files selected for processing (1)

apps/api-client-go/api/openapi.yaml

coderabbitai · 2026-06-12T10:49:35Z

        assignedRoleIds:
-          default:
-          - 00000000-0000-0000-0000-000000000001
+          default: []


⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash # Verify whether generated client defaults/serialization align with OpenAPI default: [] set -euo pipefail echo "Checking UpdateOrganizationMemberAccess defaults + serialization" rg -n -A12 -B3 'func NewUpdateOrganizationMemberAccessWithDefaults\(\)' apps/api-client-go/model_update_organization_member_access.go rg -n -A12 -B3 'func \(o UpdateOrganizationMemberAccess\) ToMap\(\)' apps/api-client-go/model_update_organization_member_access.go echo "Checking CreateOrganizationInvitation defaults + serialization" rg -n -A12 -B3 'func NewCreateOrganizationInvitationWithDefaults\(\)' apps/api-client-go/model_create_organization_invitation.go rg -n -A12 -B3 'func \(o CreateOrganizationInvitation\) ToMap\(\)' apps/api-client-go/model_create_organization_invitation.go echo "Checking required-property validation on assignedRoleIds" rg -n -A10 -B2 'requiredProperties := \[]string\{' apps/api-client-go/model_create_organization_invitation.go

Repository: boxlite-ai/boxlite

Length of output: 2912

🏁 Script executed:

#!/bin/bash set -euo pipefail echo "OpenAPI context around 9568/9598" sed -n '9545,9615p' apps/api-client-go/api/openapi.yaml echo "Inspect UpdateOrganizationMemberAccess struct fields + AssignedRoleIds type" rg -n "type UpdateOrganizationMemberAccess struct" -n apps/api-client-go/model_update_organization_member_access.go rg -n "AssignedRoleIds" apps/api-client-go/model_update_organization_member_access.go | head -n 50 sed -n '1,140p' apps/api-client-go/model_update_organization_member_access.go echo "Inspect CreateOrganizationInvitation struct fields + AssignedRoleIds type" rg -n "type CreateOrganizationInvitation struct" -n apps/api-client-go/model_create_organization_invitation.go rg -n "AssignedRoleIds" apps/api-client-go/model_create_organization_invitation.go | head -n 80 sed -n '1,230p' apps/api-client-go/model_create_organization_invitation.go echo "Find how ToMap() output is used/JSON marshaled in request bodies" rg -n "ToMap\(\)" apps/api-client-go | rg -n "UpdateOrganizationMemberAccess|CreateOrganizationInvitation" | head -n 80 rg -n "UpdateOrganizationMemberAccessWithDefaults|CreateOrganizationInvitationWithDefaults" apps/api-client-go | head -n 80 # Also check whether request code uses json.Marshal(ToMap) or something that could transform nil->[]. rg -n "json\.Marshal\(.*ToMap\(\)" apps/api-client-go | head -n 80 rg -n "ToMap\(\).*json" apps/api-client-go | head -n 80

Repository: boxlite-ai/boxlite

Length of output: 14920

OpenAPI default [] for assignedRoleIds isn’t applied by the Go client defaults

UpdateOrganizationMemberAccess.assignedRoleIds and CreateOrganizationInvitation.assignedRoleIds are required and set to default: [] in apps/api-client-go/api/openapi.yaml, but both NewUpdateOrganizationMemberAccessWithDefaults() and NewCreateOrganizationInvitationWithDefaults() only set Role and leave AssignedRoleIds as the Go zero value (nil slice). Since ToMap()/MarshalJSON() always serializes assignedRoleIds from AssignedRoleIds, requests built from these defaults can send assignedRoleIds: null instead of [], creating a schema/contract mismatch.

Also applies to: 9598-9598

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/api-client-go/api/openapi.yaml` at line 9568, Constructors NewUpdateOrganizationMemberAccessWithDefaults and NewCreateOrganizationInvitationWithDefaults leave AssignedRoleIds as nil which causes ToMap()/MarshalJSON() to emit null instead of the OpenAPI default []; update these constructors (and any similar factory funcs referenced around the other occurrence) to initialize AssignedRoleIds to an empty slice (e.g., make([]Type, 0)) so the generated ToMap()/MarshalJSON() serializes assignedRoleIds as [] and matches the OpenAPI default; reference AssignedRoleIds, NewUpdateOrganizationMemberAccessWithDefaults, NewCreateOrganizationInvitationWithDefaults, and ToMap()/MarshalJSON() when making the change.

Merging the substantive bits of #745 and #746 here so PR #724's deploy-app-services CI can actually push an otel-collector image: * otel-collector/builder-config.yaml: fix module paths after #730 moved everything under apps/ (was: ../../../api-client-go etc., now: ../../../apps/api-client-go). The OCB build was failing with `filepath does not exist: /boxlite/otel-collector/exporter`. (#745) * otel-collector/Dockerfile: apk add python3 make g++ so node-gyp can compile any musl-incompatible native add-on during workspace `yarn install`. Kept even after dropping dockerode below — small safety net in case future deps reintroduce a native build. (#745) * apps/package.json: drop unused dockerode + @types/dockerode. They were inherited from the Daytona import in #460 but never imported in source. Drops the dockerode -> docker-modem -> ssh2 -> cpu-features chain; cpu-features was the optional native addon that forced the toolchain workaround in the first place. (#746) * apps/yarn.lock: regenerated (-161 lines). * apps/api-client-go/api/openapi.yaml: regenerate to catch up with main's existing `assignedRoleIds.default: []` drift so the api-client-drift PR check passes.

… gone The previous commit kept #745's apk add as a safety net, but cpu-features was the only musl-incompatible native dep in the workspace and it came in only via the now-removed dockerode chain. Verified locally: yarn install on node:22-alpine completes without any compiler toolchain.

G4614 · 2026-06-12T11:49:56Z

Closing — see follow-up plan

G4614 added 2 commits June 12, 2026 16:09

fix(otel-collector): add python3/make/g++ to build stage for native n…

1687362

…pm add-ons (cpu-features)

fix(otel-collector): update builder-config paths for codex's apps/ mo…

385c404

…norepo layout (#730)

G4614 requested a review from a team as a code owner June 12, 2026 10:07

chore(apps): regenerate API clients (assignedRoleIds default empty)

3b12c3a

coderabbitai Bot reviewed Jun 12, 2026

View reviewed changes

G4614 mentioned this pull request Jun 12, 2026

chore(apps): drop unused dockerode dependency #746

Closed

G4614 closed this Jun 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(otel-collector): unblock Docker build after #730 apps/ normalization#745

fix(otel-collector): unblock Docker build after #730 apps/ normalization#745
G4614 wants to merge 3 commits into
mainfrom
fix/otel-collector-build

G4614 commented Jun 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 12, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jun 12, 2026

Uh oh!

G4614 commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

G4614 commented Jun 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Background

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

G4614 commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

G4614 commented Jun 12, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 12, 2026 •

edited

Loading