refactor: reorganize workspace into src/ layout#419
Merged
Conversation
Move all Rust crates under src/ with short directory names, and vendored C sys crates under src/deps/. This clears 7 crate directories from the repo root, giving a clean three-way split: src/ (Rust), sdks/ (language bindings), and supporting dirs (docs, examples, scripts). Directory mapping: - boxlite/ → src/boxlite/ - boxlite-cli/ → src/cli/ - boxlite-server/ → src/server/ - boxlite-shared/ → src/shared/ - ffi/ → src/ffi/ - guest/ → src/guest/ - test-utils/ → src/test-utils/ - boxlite/deps/*-sys → src/deps/*-sys Updated: workspace Cargo.toml, per-crate path dependencies, SDK paths, .gitmodules, CI workflows, Makefile, codecov, pre-commit, and docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The gitignore rules for libgvproxy-sys vendor/ and libkrun-sys target/ still referenced the old boxlite/deps/ paths. After git mv, 1570 Go vendor files and a binary were accidentally committed. Remove them from tracking and update the ignore rules to use src/deps/ paths.
DorianZheng
added a commit
that referenced
this pull request
Apr 2, 2026
…t reorganization After PR #419 moved crates under src/, CARGO_MANIFEST_DIR.parent() resolved to src/ instead of the repo root. This caused find_prebuilt_shim/guest to search src/target/ (doesn't exist) instead of target/, resulting in runtime tarballs missing boxlite-guest and boxlite-shim. Replace the .parent() heuristic with find_workspace_root() that walks up the directory tree looking for a Cargo.toml containing [workspace]. Also bumps all SDK versions to 0.8.2.
5 tasks
DorianZheng
added a commit
that referenced
this pull request
Apr 2, 2026
* fix(build): fix workspace root detection in build.rs after src/ layout reorganization After PR #419 moved crates under src/, CARGO_MANIFEST_DIR.parent() resolved to src/ instead of the repo root. This caused find_prebuilt_shim/guest to search src/target/ (doesn't exist) instead of target/, resulting in runtime tarballs missing boxlite-guest and boxlite-shim. Replace the .parent() heuristic with find_workspace_root() that walks up the directory tree looking for a Cargo.toml containing [workspace]. Also bumps all SDK versions to 0.8.2. * fix(node): remove stale optionalDependencies pinned to 0.8.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/with short Firecracker-style names (e.g.,boxlite-cli/→src/cli/)boxlite/deps/tosrc/deps/Motivation
The repo root was cluttered with 7 crate directories mixed with non-crate dirs. This reorganization gives a clean three-way split:
src/(Rust),sdks/(language bindings), and supporting dirs.Test plan
cargo metadata --no-depsresolves all workspace membersgit submodule statusshows correct new pathssrc/**path changesmake testpasses (unit tests)