Fix reading versions from cache directory.#1076
Merged
wibblymat merged 1 commit intobower:masterfrom Feb 3, 2014
gregberge:fix-cache-directory-reading
Merged
Fix reading versions from cache directory.#1076wibblymat merged 1 commit intobower:masterfrom gregberge:fix-cache-directory-reading
wibblymat merged 1 commit intobower:masterfrom
gregberge:fix-cache-directory-reading
Conversation
When we write into directory we use encodeURIComponent, but when we read, we did nothing. Now we use decodeURIComponent to read the correct version and match the correct cache directory.
|
Does it means there are a lot of downloads done for nothing? |
Contributor
Author
|
@vvo yes, I think GitHub will ❤️ me. |
|
👍 on this patch. CI breaking sucks :(. |
Member
|
Looks good, @wibblymat ? |
Member
|
I'm happy with the change! |
wibblymat
added a commit
that referenced
this pull request
Feb 3, 2014
Fix reading versions from cache directory.
Member
|
Fixes #933? |
Contributor
Author
|
No, it just decreases chances of bug, but only #1077 completely fixes them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we write into directory we use encodeURIComponent, but when we read, we did nothing. Now we use decodeURIComponent to read the correct version and match the correct cache directory.
Actually, all tag containing a "+" (example "v1.2.11-build.2185+sha.4f735b0") are not correctly read from cache.
Fix #1075