Use kubernetes device-ownership setting#329
Merged
vigh-m merged 1 commit intobottlerocket-os:developfrom Jan 2, 2025
Merged
Conversation
Merged
1 task
dfb2a94 to
b68e6be
Compare
ytsssun
reviewed
Dec 23, 2024
yeazelm
approved these changes
Dec 30, 2024
ytsssun
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
packages/containerd/containerd-config-toml_k8s_containerd_sockto support the new setting being added in feat: Add kubernetes device ownership bottlerocket-settings-sdk#69. This is to support the same setting in the containerd CRI plugin as described hereTesting done:
The setting shows up as expected in an AMI built using this
settings-sdkChanging the setting works as defined:
The setting has the desired effect on device ownership
true:false:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.