feat: Add kubernetes device ownership#69
Merged
vigh-m merged 2 commits intobottlerocket-os:developfrom Dec 24, 2024
Merged
Conversation
a82821f to
7376696
Compare
This was referenced Dec 21, 2024
Contributor
|
The change looks good but nit about the commit message: I'd like a basic explanation about the change more than just the title to help folks piece together what it is intended for or why it was added since this is in a different repo from where the interesting parts will land. |
yeazelm
approved these changes
Dec 23, 2024
7376696 to
1309714
Compare
Contributor
Author
|
Ack. Updated the commit message with some more context. |
Add a new setting to gate the containerd CRI plugin `device-ownership-from-security-context`. This option will allow containers to gain ownership of requested devices without needing root containers or devices.
1309714 to
288b2ba
Compare
ytsssun
approved these changes
Dec 24, 2024
cbgbt
reviewed
Dec 24, 2024
2bbeec6 to
f1b216a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
device-ownership-from-security-contextboolean. This is to support the same setting in the containerd CRI plugin as described hereTesting done:
The setting shows up as expected in an AMI built using this
settings-sdkChanging the setting works as defined:
The setting has the desired effect on device ownership
true:false:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.