Skip to content

devcontainer and deployment e2e test #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frol merged 20 commits into from
Aug 23, 2024
Merged

devcontainer and deployment e2e test #99

frol merged 20 commits into from
Aug 23, 2024

Conversation

@petersalomonsen
Copy link
Contributor

@petersalomonsen petersalomonsen commented Aug 18, 2024 •
edited
Loading

Add a devcontainer setup for use with github codespaces.

Add a test for deployment, with a github action.

The test config and mocks are placed in a separate file, to be reusable for additional future tests.

@frol
Copy link
Collaborator

frol commented Aug 21, 2024

@petersalomonsen #98 got all the dependencies upgraded to the latest version. Please, rebase

@petersalomonsen
Copy link
Contributor Author

petersalomonsen commented Aug 21, 2024

@petersalomonsen #98 got all the dependencies upgraded to the latest version. Please, rebase

will do, btw do you think adding an e2e test for deployment still has value? As part of bumping the version of near-socialdb-client, I also started working on tests for this. Let me know if you think this would still be a valuable contribution. @frol

@petersalomonsen petersalomonsen force-pushed the near-socialdb-client-0.3.2 branch from 8321984 to 75ea440 Compare August 21, 2024 17:57
@petersalomonsen petersalomonsen changed the title devcontainer and near-socialdb-client-0.3.2 devcontainer and deployment e2e test Aug 21, 2024
@frol
Copy link
Collaborator

frol commented Aug 21, 2024

will do, btw do you think adding an e2e test for deployment still has value?

@petersalomonsen It would be amazing to have the e2e test! I have already checked it out and it makes total sense! Please, add a new workflow to run the tests on CI

@petersalomonsen petersalomonsen mentioned this pull request Aug 22, 2024
Closed
frol
frol reviewed Aug 22, 2024
View reviewed changes
@petersalomonsen
Copy link
Contributor Author

petersalomonsen commented Aug 23, 2024

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Aug 23, 2024 •
edited
Loading

@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 13

Your contribution is much appreciated with a final score of 13!
You have received 158 (130 base + 20 monthly bonus + 5% lifetime bonus) Sloth points for this contribution

Congratulations @petersalomonsen! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@petersalomonsen petersalomonsen marked this pull request as ready for review August 23, 2024 04:49
@petersalomonsen petersalomonsen requested a review from frol August 23, 2024 04:49
frol
frol approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 13

Adding first e2e test is always the hardest step in figuring out the approach. Thank you @petersalomonsen for making that step!

@frol frol merged commit 92673b7 into bos-cli-rs:main Aug 23, 2024
@frol frol mentioned this pull request Aug 23, 2024
Merged
@petersalomonsen petersalomonsen deleted the near-socialdb-client-0.3.2 branch August 23, 2024 17:21
frol added a commit that referenced this pull request Sep 3, 2024
@frol
chore: release v0.3.17 (#100)
5c27833 
## 🤖 New release
* `bos-cli`: 0.3.16 -> 0.3.17

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.3.17](v0.3.16...v0.3.17)
- 2024-09-03

### Added
- Added TEACH-ME mode (activate it with `bos --teach-me`)
([#101](#101))

### Other
- devcontainer and deployment e2e test
([#99](#99))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frol frol frol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@petersalomonsen @frol @race-of-sloths