install: Allocate a global tmpdir#730
Merged
cgwalters merged 2 commits intobootc-dev:mainfrom Jul 26, 2024
Merged
Conversation
Collaborator
Author
|
Having a nice clean git history with a lot of incrementally justified and tested commits is nice, but some days the merge conflicts with one's own work gets tedious 😄 |
We allocate temporary things in a few places, and it's handy to have a pre-created single directory for the whole install process to use instead of creating individual tempfiles. Signed-off-by: Colin Walters <walters@verbum.org>
We create a transient ostree repo, to do so use the global install tmpdir. Signed-off-by: Colin Walters <walters@verbum.org>
c0d1a7a to
e7be393
Compare
jeckersb
approved these changes
Jul 26, 2024
cgwalters
added a commit
to cgwalters/bootc
that referenced
this pull request
Nov 5, 2024
Convert to `let-else` syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install: Allocate a global tmpdir
We allocate temporary things in a few places, and it's
handy to have a pre-created single directory for the
whole install process to use instead of creating
individual tempfiles.
Signed-off-by: Colin Walters walters@verbum.org
install: Use tmpdir for target fetch verification
We create a transient ostree repo, to do so use the global
install tmpdir.
Signed-off-by: Colin Walters walters@verbum.org