lib: Remove composefs-backend feature gate#1708
Merged
cgwalters merged 1 commit intobootc-dev:mainfrom Oct 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the composefs-backend feature gate, making the composefs functionality a core part of the library. This is a good simplification of the codebase, removing a significant amount of conditional compilation logic. The changes have been applied consistently, and the logic that was previously split between the feature being enabled or disabled has been correctly unified. The documentation has also been updated to reflect this change. The pull request looks solid.
Collaborator
Author
|
Hmm interesting the c9s install is timing out here too, this may be a generic bug |
cgwalters
added a commit
that referenced
this pull request
Oct 28, 2025
GitHub Actions runners are nested VMs, and bcvk's use of virtiofs causes systemd-journald to enter a livelock when writing to persistent storage in nested virtualization environments. Add the kernel argument systemd.journald.storage=volatile to force journald to use tmpfs instead, which avoids the livelock. This workaround is needed until bcvk issue #90 is fully resolved upstream. Fixes: #1708 (comment) Related: bootc-dev/bcvk#90 Assisted-by: Claude Code (Sonnet 4.5)
While composefs is still experimental, after looking at this I think the feature gating we're doing has a pretty high "pain:gain" ratio - in other words, the risk we're mitigating by having it off is very low. Since composefs is a focus of development, let's just remove the feature gate. We have good CI coverage for the non-composefs case. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <walters@verbum.org>
6f8b0ed to
22e0cee
Compare
Johan-Liebert1
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While composefs is still experimental, after looking at this I think the feature gating we're doing has a pretty high "pain:gain" ratio - in other words, the risk we're mitigating by having it off is very low.
Since composefs is a focus of development, let's just remove the feature gate. We have good CI coverage for the non-composefs case.
Assisted-by: Claude Code (Sonnet 4.5)