Skip to content

Conversation

@jhoward-lm
Copy link
Contributor

@jhoward-lm jhoward-lm commented Jun 5, 2024

Update to use Protobom Ent backend

Description

Update to use the protobom Ent storage backend for interacting with bomctl database.

Type of change

  • Refactor

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@jhoward-lm jhoward-lm added the enhancement New feature or request label Jun 5, 2024
@jhoward-lm jhoward-lm self-assigned this Jun 5, 2024
@jhoward-lm
Copy link
Contributor Author

Going to break this into follow-on issues and separate PRs to keep these changes small.

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm marked this pull request as ready for review June 10, 2024 15:12
@jhoward-lm jhoward-lm requested a review from a team as a code owner June 10, 2024 15:12
Copy link
Member

@idunbarh idunbarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited to see this PR merged!

@jhoward-lm jhoward-lm marked this pull request as draft June 10, 2024 16:24
@jhoward-lm
Copy link
Contributor Author

Putting back into draft until @puerco is able to merge protobom/storage#12 and cut a release so that this repo's go.mod can be updated

Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
@jhoward-lm jhoward-lm marked this pull request as ready for review June 10, 2024 20:36
@jhoward-lm jhoward-lm merged commit 4ebb08f into main Jun 10, 2024
@jhoward-lm jhoward-lm deleted the ent-backend branch June 10, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants