Fix unique index definitions #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
Signed-off-by: Jonathan Howard <jonathan.w.howard@lmco.com>
10 tasks
Contributor
Author
|
@eddiezane @houdini91 @cpanato requesting review, I couldn't add to the reviewers directly All changes are auto-generated except:
|
puerco
approved these changes
Jun 10, 2024
Member
puerco
left a comment
There was a problem hiding this comment.
One non-blocking question but looks good to me
|
|
||
| func (backend *Backend) Debug() *Backend { | ||
| backend.Options.Debug = true | ||
| backend.client.Debug() |
Member
There was a problem hiding this comment.
Is this breaking something with the client? or why would we not want to debug the client?
Contributor
Author
There was a problem hiding this comment.
Yeah, at this point, client isn't initialized yet. It just sets the debug flag in the options, then in InitClient() this gets run:
clientOpts := []ent.Option{}
if backend.Options.Debug {
clientOpts = append(clientOpts, ent.Debug())
}
client, err := ent.Open("sqlite3", backend.Options.DatabaseFile+dsnParams, clientOpts...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes for schema unique index definitions and
Documentrelations.Document
Metadata.IDstring as IDDocumentas owner of itsNodeListandMetadataedges (reverseedge.To()andedge.From()definitions in schemas)Metadata.ID) as a field inNodeListschemaExternalReference
URLandTypefieldsNodeList
DocumentIDfieldMiscellaneous
nilat the time of calling itsDebug()method)