-
Notifications
You must be signed in to change notification settings - Fork 19
feat: bomctl push subcommand git client functionality #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
300835e to
035a40b
Compare
jhoward-lm
reviewed
Aug 14, 2024
jhoward-lm
reviewed
Aug 15, 2024
jhoward-lm
reviewed
Aug 20, 2024
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
eb2d013 to
0692a29
Compare
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
jhoward-lm
approved these changes
Aug 22, 2024
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
mfrystacky
reviewed
Aug 28, 2024
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few improvements to polish this
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
c15db32 to
5bdcde2
Compare
mfrystacky
approved these changes
Aug 29, 2024
Contributor
mfrystacky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more changes to consider
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
pkwiatkowski1
pushed a commit
to pkwiatkowski1/bomctl
that referenced
this pull request
Sep 5, 2024
* feat: push subcmd git client with tree handling Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com> --------- Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
go run main.go push -v --netrc <id> git+https://github.com/repo/path.git@<branch>#<path/to/filename>Fetch Prior to push (just pulling a bom that has external refs to grab, Thanks Ian)
bomctl fetch https://raw.githubusercontent.com/bomctl/bomctl-playground/main/examples/bomctl-container-image/bomctl_bomctl_v0.3.0.cdx.jsonPush with Tree (check to make sure the ID matches in your local db)
bomctl push -vv --tree --netrc urn:uuid:f360ad8b-dc41-4256-afed-337a04dff5db git+https://github.com/repo/path.git@<branch>#<path/to/filename>Adds Push functionality for git client. small refactor of git fetch to avoid duplication.
Fixes #126
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Needs Tests
Checklist