Skip to content

Conversation

@ashearin
Copy link
Member

@ashearin ashearin commented Aug 9, 2024

Pull Request Template

Description

go run main.go push -v --netrc <id> git+https://github.com/repo/path.git@<branch>#<path/to/filename>

Fetch Prior to push (just pulling a bom that has external refs to grab, Thanks Ian)
bomctl fetch https://raw.githubusercontent.com/bomctl/bomctl-playground/main/examples/bomctl-container-image/bomctl_bomctl_v0.3.0.cdx.json

Push with Tree (check to make sure the ID matches in your local db)
bomctl push -vv --tree --netrc urn:uuid:f360ad8b-dc41-4256-afed-337a04dff5db git+https://github.com/repo/path.git@<branch>#<path/to/filename>

Adds Push functionality for git client. small refactor of git fetch to avoid duplication.

Fixes #126

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Needs Tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ashearin ashearin self-assigned this Aug 9, 2024
@ashearin ashearin requested a review from a team as a code owner August 9, 2024 00:58
@ashearin ashearin linked an issue Aug 9, 2024 that may be closed by this pull request
@ashearin ashearin marked this pull request as draft August 9, 2024 00:59
@ashearin ashearin force-pushed the 126-push-subcommand-git-client-functionality branch 2 times, most recently from 300835e to 035a40b Compare August 13, 2024 03:12
@ashearin ashearin marked this pull request as ready for review August 20, 2024 12:43
@ashearin ashearin changed the title Draft: 126 push subcommand git client functionality bomctl push subcommand git client functionality Aug 20, 2024
@ashearin ashearin changed the title bomctl push subcommand git client functionality feat: bomctl push subcommand git client functionality Aug 21, 2024
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
@ashearin ashearin force-pushed the 126-push-subcommand-git-client-functionality branch from eb2d013 to 0692a29 Compare August 22, 2024 14:24
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
@jhoward-lm jhoward-lm added the enhancement New feature or request label Aug 22, 2024
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Copy link
Contributor

@mfrystacky mfrystacky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few improvements to polish this

Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
@ashearin ashearin force-pushed the 126-push-subcommand-git-client-functionality branch from c15db32 to 5bdcde2 Compare August 28, 2024 20:27
Copy link
Contributor

@mfrystacky mfrystacky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes to consider

Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
@ashearin ashearin merged commit dc319c6 into main Aug 29, 2024
@ashearin ashearin deleted the 126-push-subcommand-git-client-functionality branch August 29, 2024 17:36
pkwiatkowski1 pushed a commit to pkwiatkowski1/bomctl that referenced this pull request Sep 5, 2024
* feat: push subcmd git client with tree handling

Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>

---------

Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Push Subcommand: Git client functionality

4 participants