This repository was archived by the owner on Mar 9, 2019. It is now read-only.
Add truncate() and sync() on resize.#286
Merged
benbjohnson merged 1 commit intoboltdb:masterfrom Jan 18, 2015
Merged
Conversation
This commit fixes an issue with ext3/ext4 filesystems where metadata file size is not synced when resizing a file. It also resizes the entire resize instead of updating the size during individual page writes. Thanks to @tv42 for the fix.
Member
Author
|
@tv42 how does this look? |
Contributor
|
Can't see anything wrong with it. As the paper pointed out, there's a devil in every detail ;) |
Member
Author
|
cool, thanks for looking it over. |
benbjohnson
added a commit
that referenced
this pull request
Jan 18, 2015
Add truncate() and sync() on resize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This commit fixes an issue with ext3/ext4 filesystems where metadata file size is not synced when resizing a file. It also resizes the entire resize instead of updating the size during individual page writes.
Fixes #284.
Thanks to @tv42 for the fix.